fix: use typemap in JVM #2556
Merged
fix: use typemap in JVM #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
jvmakine
and removed request for
a team
stuartwdouglas
added
the
run-all
stuartwdouglas
force-pushed
the
stuartwdouglas/2510
branch
from
b62128f to
4eb66a1
Compare
alecthomas
reviewed
Aug 30, 2024
go.mod
Outdated
| @@ -47,6 +47,7 @@ require ( | |||
| github.com/santhosh-tekuri/jsonschema/v5 v5.3.1 | |||
| github.com/sqlc-dev/pqtype v0.3.0 | |||
| github.com/swaggest/jsonschema-go v0.3.72 | |||
| github.com/tbd54566975/web5-go v0.24.0 | |||
There was a problem hiding this comment.
It looks like this was added just to get a type to use for testing, but this will slow down the builds, so let's remove it and use some type in the stdlib or something.
There was a problem hiding this comment.
Is it ok to keep using it in the testdata project (so it is not in the main go.mod, just the test project used in integration tests).
Using this class actually showed up some real world issues as it has a custom serialization format, and was supported in both languages via third party libraries.
jvm-runtime/ftl-runtime/common/runtime/src/main/java/xyz/block/ftl/runtime/VerbHandler.java
Outdated
Show resolved
Hide resolved
stuartwdouglas
force-pushed
the
stuartwdouglas/2510
branch
2 times, most recently
from
7459ffe to
9d67773
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stuartwdouglas
force-pushed
the
stuartwdouglas/2510
branch
from
9d67773 to
2f21934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2513
fixes: #2510