feat: add infrastructure tabs and state #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
force-pushed
the
display-status-info
branch
from
772b013 to
2020ecd
Compare
deniseli
approved these changes
Aug 29, 2024
frontend/e2e/infrastructure.spec.ts
Outdated
| await infrastructureNavItem.click() | ||
| await expect(page).toHaveURL(/\/infrastructure$/) | ||
|
|
||
| const controllersTab = await page.getByRole('button', { name: 'Controllers' }); |
There was a problem hiding this comment.
Looks like the tabbing got a little messed up here?
There was a problem hiding this comment.
Ah yeah, biome was ignoring the e2e folder. Fixed!
| setSearchParams({ tab: tabId }) | ||
| } | ||
|
|
||
| const currentTab = searchParams.get('tab') || tabs[0].id |
There was a problem hiding this comment.
What do you think about making the tab part of the path? Since these tabs are basically sub-pages of the Infrastructure page, that feels a little more canonical. Query params work too, though.
There was a problem hiding this comment.
Yeah it's a good question! I think for now I might leave the params and as I build this out re-evaluate the best solution here. Good call out!
deniseli
approved these changes
Aug 29, 2024
| @@ -1,11 +1,11 @@ | |||
| { | |||
| "extends": ["../biome.json"], | |||
| "linter": { | |||
| "include": ["src/**/*.ts", "src/**/*.tsx", "src/**/*.js", "src/**/*.jsx", "src/**/*.cjs", "src/**/*.mjs", "tests/**/*.ts"], | |||
| "include": ["src/**/*.ts", "src/**/*.tsx", "src/**/*.js", "src/**/*.jsx", "src/**/*.cjs", "src/**/*.mjs", "tests/**/*.ts", "e2e/**/*.ts"], | |||
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
wesbillman
force-pushed
the
display-status-info
branch
from
586d21e to
e07a6b0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
wesbillman
added
the
run-all
wesbillman
force-pushed
the
display-status-info
branch
from
e07a6b0 to
ee7f79a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
wesbillman
force-pushed
the
display-status-info
branch
from
ee7f79a to
ae78a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2552
Also created new
TabsandPillcomponents