Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make roadmap issues mini dashboards #2520

Merged

Conversation

worstell
Copy link
Contributor

No description provided.

@worstell worstell requested a review from alecthomas as a code owner August 28, 2024 15:57
@worstell worstell requested a review from a team August 28, 2024 15:57
@ftl-robot ftl-robot mentioned this pull request Aug 28, 2024
@@ -27,14 +27,34 @@ concurrency:
jobs:
update-workflow-issue:
runs-on: ubuntu-latest
strategy:
matrix:
label: ["jvm"] # add if desired: "codebase-health", "core", "infrastructure", "go", "security", "dx"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @TBD54566975/ftl-team if you want to automate your roadmap dashboards, you can opt in here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worstell the dx board is ready to go if you want use us as another test team for this :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesbillman added dx!

@worstell worstell force-pushed the worstell/20240827-make-roadmap-issues-mini-dashboards branch from 27beca6 to 0a6514f Compare August 28, 2024 16:08
@worstell worstell added this pull request to the merge queue Aug 28, 2024
@worstell worstell removed this pull request from the merge queue due to a manual request Aug 28, 2024
@worstell worstell force-pushed the worstell/20240827-make-roadmap-issues-mini-dashboards branch from 0a6514f to fcfdef7 Compare August 28, 2024 17:58
permissions:
issues: write
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: cashapp/activate-hermit@v1
- run: update-workflow-issue
- run: |
declare -A label_to_issue_map=(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@@ -1,4 +1,4 @@
name: Update roadmap issue #728
name: Update roadmap issues
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is that we might hit GitHub API limits, particularly when we're triaging and there's a flurry of activity.

If we start hitting issues I think we have some options, some basic optimisations are probably possible, and potentially combining all updates into a single script, merging some calls.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll combine these into a single workflow for now, since the triggers are the same

@@ -0,0 +1,102 @@
#!/bin/bash

label="$1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do a check for presence here and dump some usage info for anyone who runs it without args?

@alecthomas
Copy link
Collaborator

I was thinking too, that we should link to the individual team roadmaps from the main roadmap.

@worstell worstell force-pushed the worstell/20240827-make-roadmap-issues-mini-dashboards branch from fcfdef7 to 77ba88e Compare August 28, 2024 20:52
@worstell worstell enabled auto-merge August 28, 2024 20:54
@worstell worstell added this pull request to the merge queue Aug 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@worstell worstell force-pushed the worstell/20240827-make-roadmap-issues-mini-dashboards branch 2 times, most recently from 88b88e0 to decb10a Compare August 29, 2024 17:13
@worstell worstell mentioned this pull request Aug 29, 2024
@worstell worstell force-pushed the worstell/20240827-make-roadmap-issues-mini-dashboards branch from decb10a to e6af23a Compare August 29, 2024 18:36
@worstell worstell enabled auto-merge August 29, 2024 18:37
@worstell worstell added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@worstell worstell added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@worstell worstell added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit f84f7b8 Aug 29, 2024
19 checks passed
@worstell worstell deleted the worstell/20240827-make-roadmap-issues-mini-dashboards branch August 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants