Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add titles (show on hover) to truncate-able columns in console tables #2465

Merged
merged 3 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/features/timeline/TimelineCall.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import type { CallEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb
import { verbRefString } from '../verbs/verb.utils'

export const TimelineCall = ({ call }: { call: CallEvent }) => {
const title = `${call.sourceVerbRef?.module ? `${verbRefString(call.sourceVerbRef)} -> ` : ''}${call.destinationVerbRef ? verbRefString(call.destinationVerbRef) : ''}`
return (
<span>
<span title={title}>
{call.sourceVerbRef?.module && (
<>
<span className='text-indigo-500 dark:text-indigo-300'>{verbRefString(call.sourceVerbRef)}</span>
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/features/timeline/TimelineDeploymentCreated.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import type { DeploymentCreatedEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb'

export const TimelineDeploymentCreated = ({ deployment }: { deployment: DeploymentCreatedEvent }) => {
const title = `Created deployment ${deployment.key} for language ${deployment.language}`
return (
<>
<span title={title}>
Created deployment <span className='text-indigo-500 dark:text-indigo-300'>{deployment.key}</span> for language{' '}
<span className='text-indigo-500 dark:text-indigo-300'>{deployment.language}</span>
</>
</span>
)
}
5 changes: 3 additions & 2 deletions frontend/src/features/timeline/TimelineDeploymentUpdated.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import type { DeploymentUpdatedEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb'

export const TimelineDeploymentUpdated = ({ deployment }: { deployment: DeploymentUpdatedEvent }) => {
const title = `Updated deployment ${deployment.key} min replicas to ${deployment.minReplicas} (previously ${deployment.prevMinReplicas})`
return (
<>
<span title={title}>
Updated deployment <span className='text-indigo-500 dark:text-indigo-300'>{deployment.key}</span> min replicas to{' '}
<span className='text-indigo-500 dark:text-indigo-300'>{deployment.minReplicas}</span> (previously{' '}
<span className='text-indigo-500 dark:text-indigo-300'>{deployment.prevMinReplicas}</span>)
</>
</span>
)
}
2 changes: 1 addition & 1 deletion frontend/src/features/timeline/TimelineLog.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { LogEvent } from '../../protos/xyz/block/ftl/v1/console/console_pb'

export const TimelineLog = ({ log }: { log: LogEvent }) => {
return <span>{log.message}</span>
return <span title={log.message}>{log.message}</span>
}
Loading