Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix browser resizing + scrolling bug on console table rendering #2464

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

deniseli
Copy link
Contributor

Set min width on console's calls table to prevent tbody rows from getting chopped.

Steps to reproduce:

  1. Make browser window so small that the table cannot fit
  2. Scroll to the table all the way to the right to see the full Error column
  3. Observe how the border lies too far to the left, chopping off the contents of the table below the header.
Screenshot 2024-08-20 at 4 35 17 PM

Before fix:
Screenshot 2024-08-20 at 4 35 40 PM

Issue: #2460

@deniseli deniseli marked this pull request as ready for review August 20, 2024 20:38
@deniseli deniseli requested a review from alecthomas as a code owner August 20, 2024 20:38
@deniseli deniseli requested review from a team and jonathanj-square and removed request for a team August 20, 2024 20:38
@ftl-robot ftl-robot mentioned this pull request Aug 20, 2024
@wesbillman wesbillman added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@deniseli deniseli added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 99d18f6 Aug 20, 2024
19 checks passed
@deniseli deniseli deleted the dli/table-width branch August 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants