chore: add console e2e testing with playwright #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
added
the
run-all
Open
wesbillman
force-pushed
the
add-playwright-tests
branch
from
3be5c3a to
6aa4901
Compare
wesbillman
removed
the
run-all
wesbillman
force-pushed
the
add-playwright-tests
branch
3 times, most recently
from
ae8d14c to
18b9e13
Compare
deniseli
approved these changes
Aug 20, 2024
frontend/tests/verb.spec.ts
Outdated
| const sendButton = page.getByText('Send') | ||
| await sendButton.click() | ||
|
|
||
| await expect(page.getByText('{"message":"Hello')).toBeVisible({ timeout: 30000 }) |
There was a problem hiding this comment.
Does the timeout need to be this long?
There was a problem hiding this comment.
I'm going to remove that test for now, it's flakey :)
wesbillman
force-pushed
the
add-playwright-tests
branch
from
18b9e13 to
a4d9c04
Compare
|
@alecthomas I feel like maybe this should move to integration tests instead of CI, whatcha think? Do we have a way to add non-go tests to the integration workflow in CI? Maybe not a massive issue yet, since this seems faster than the |
|
I'm gonna merge this one and follow up with a PR to move these to run in the merge queue and separate out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2416