Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Java tests for catch<Any> #2428

Merged
merged 1 commit into from
Aug 19, 2024
Merged

chore: Java tests for catch<Any> #2428

merged 1 commit into from
Aug 19, 2024

Conversation

stuartwdouglas
Copy link
Collaborator

fixes: #2427

@stuartwdouglas stuartwdouglas requested review from a team and wesbillman and removed request for a team August 19, 2024 04:58
@ftl-robot ftl-robot mentioned this pull request Aug 19, 2024
Open
matt2e
matt2e approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@matt2e matt2e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit f9214f8 Aug 19, 2024
18 checks passed
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/2427 branch August 19, 2024 07:38
@wesbillman wesbillman added the approved Marks an already closed PR as approved label Aug 19, 2024
safeer pushed a commit that referenced this pull request Aug 19, 2024
@stuartwdouglas @safeer
chore: Java tests for catch<Any> (#2428)
1d3207b 
fixes: #2427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt2e matt2e matt2e approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@wesbillman wesbillman Awaiting requested review from wesbillman

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow catch verbs in jvm with CatchRequest<Any>
3 participants
@stuartwdouglas @matt2e @wesbillman