feat: rewrite cron to use async system #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
safeer
commented
Aug 16, 2024
alecthomas
reviewed
Aug 18, 2024
alecthomas
reviewed
Aug 20, 2024
safeer
added
the
run-all
safeer
commented
Aug 21, 2024
safeer
force-pushed
the
saf/cron-async
branch
2 times, most recently
from
4a36b47 to
27c5c20
Compare
safeer
requested review from
a team,
jonathanj-square and
matt2e
and removed request for
a team
alecthomas
reviewed
Aug 22, 2024
backend/controller/sql/schema/20240815164808_async_calls_cron_job_key.sql
Outdated
Show resolved
Hide resolved
safeer
force-pushed
the
saf/cron-async
branch
2 times, most recently
from
c78af2e to
7810fc8
Compare
wesbillman
reviewed
Aug 23, 2024
alecthomas
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Awesome work @safeer , it feels really good to get this done.
| FROM cron_jobs j | ||
| INNER JOIN deployments d on j.deployment_id = d.id | ||
| WHERE j.key = sqlc.arg('key')::cron_job_key | ||
| FOR UPDATE SKIP LOCKED; |
There was a problem hiding this comment.
Do you want FOR UPDATE SKIP LOCKED here? Above it makes sense to me, but in this case it will not return a cron job even if it exists, in the case when it is locked.
There was a problem hiding this comment.
GetCronJobByKey is used to schedule the next execution of a completed job. Theoretically, there could be a race condition with another controller that's scheduling all cron jobs (via GetUnscheduledCronJobs), and two dupe jobs will be scheduled, so the lock is needed here to deconflict
backend/controller/sql/schema/20240815164808_async_calls_cron_job_key.sql
Show resolved
Hide resolved
safeer
force-pushed
the
saf/cron-async
branch
2 times, most recently
from
fafcba4 to
cfe16aa
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
safeer
force-pushed
the
saf/cron-async
branch
2 times, most recently
from
4d38d19 to
fe429b8
Compare
also made AsyncOriginCron type safe
This was referenced Aug 27, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor removes the cron job system's state management, cron execution, and hashring management, in favor of the async call system.
Data tables changed as follows:
cron_jobsis still used to maintain the job liststate, addslast_execution::timestampzandlast_async_call_id::bigintasync_callsis inserted to by the cron systemcron_jobs.last_async_call_id = async_calls.idcronorigin inasync_calls.originAfter a deployment, all valid unscheduled cron jobs are scheduled; a row is added to
async_callswith apendingstate andscheduled_atis set to the job's next execution time. The corresponding row incron_jobsis also updated with the scheduled async call, the computed next execution time, and the inserted async call ID.On completion of a cron async call, the next execution of that job is scheduled. Effectively, every cron job will have exactly one scheduled execution.
Closes #2197