Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename some timeline related names #2355

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: rename some timeline related names #2355

merged 1 commit into from
Aug 14, 2024

Conversation

alecthomas
Copy link
Collaborator

@alecthomas alecthomas commented Aug 14, 2024 •
edited
Loading

  1. Renamed the "events" table to "timeline" to more clearly reflect its purpose and usage.
  2. Renamed the encryption key from "logs" to "timeline" as the events table contains more than just logs. This just makes things a bit clearer.

@alecthomas alecthomas requested review from gak and a team August 14, 2024 05:57
@ftl-robot ftl-robot mentioned this pull request Aug 14, 2024
Open
@alecthomas alecthomas changed the title refactor: rename "logs" key to "events" fix: rename "logs" key to "events" Aug 14, 2024
gak
gak approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@gak gak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ez

@alecthomas alecthomas added this pull request to the merge queue Aug 14, 2024
@alecthomas alecthomas removed this pull request from the merge queue due to a manual request Aug 14, 2024
@alecthomas alecthomas force-pushed the aat/rename-logs-events branch from 91d7ad6 to 9745449 Compare August 14, 2024 06:13
@alecthomas alecthomas changed the title fix: rename "logs" key to "events" fix: rename some timeline related names Aug 14, 2024
@alecthomas alecthomas force-pushed the aat/rename-logs-events branch from 9745449 to b8e2b9f Compare August 14, 2024 06:15
@alecthomas alecthomas added the run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue label Aug 14, 2024
@alecthomas alecthomas force-pushed the aat/rename-logs-events branch from b8e2b9f to 08e1b0f Compare August 14, 2024 06:20
@alecthomas
fix: rename some timeline related names
c608d25 
Renamed the "events" table to "timeline" to more clearly reflect its
purpose and usage.

Renamed the encryption key from "logs" to "events" as the events table
contains more than just logs. This just makes things a bit clearer.
@alecthomas alecthomas force-pushed the aat/rename-logs-events branch from 08e1b0f to c608d25 Compare August 14, 2024 07:59
@alecthomas alecthomas enabled auto-merge August 14, 2024 08:02
@alecthomas alecthomas added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 306b548 Aug 14, 2024
69 checks passed
@alecthomas alecthomas deleted the aat/rename-logs-events branch August 14, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gak gak gak approved these changes

Assignees
No one assigned
Labels
run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecthomas @gak