Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: kms part 1, core encryption functionality and deprecations. #2312

Merged
merged 10 commits into from
Aug 11, 2024
Merged

wip: kms part 1, core encryption functionality and deprecations. #2312

merged 10 commits into from
Aug 11, 2024

Conversation

gak
Copy link
Contributor

@gak gak commented Aug 11, 2024 •
edited
Loading

Related #2290

Doesn't change any functionality in the system yet. It is just a refactor and new encryption types, with tests.

@ftl-robot ftl-robot mentioned this pull request Aug 11, 2024
Open
@gak gak changed the title wip: kms wip: kms part 1, core encryption functionality and deprecations. Aug 11, 2024
@gak gak marked this pull request as ready for review August 11, 2024 07:17
@gak gak requested a review from alecthomas as a code owner August 11, 2024 07:17
@gak gak requested review from a team and stuartwdouglas and removed request for a team August 11, 2024 07:17
@alecthomas
Copy link
Collaborator

I think it would be preferable not to rename the existing types, it makes it very difficult to tell what has actually changed. Add a deprecated comment instead. If there are new types call them "*Next" or something for now.

@alecthomas alecthomas requested a review from AlexSzlavik August 11, 2024 22:30
@alecthomas
Copy link
Collaborator

alecthomas
alecthomas approved these changes Aug 11, 2024
View reviewed changes
internal/encryption/encryption.go Outdated Show resolved Hide resolved
internal/encryption/encryption.go Outdated Show resolved Hide resolved
@alecthomas
Copy link
Collaborator

I think it would be preferable not to rename the existing types, it makes it very difficult to tell what has actually changed. Add a deprecated comment instead. If there are new types call them "*Next" or something for now.

Disregard for this one, but in general this is preferable.

@gak
Copy link
Contributor Author

gak commented Aug 11, 2024

I think it would be preferable not to rename the existing types, it makes it very difficult to tell what has actually changed. Add a deprecated comment

Disregard for this one, but in general this is preferable.

Too late!

@gak
Copy link
Contributor Author

gak commented Aug 11, 2024

I think it would be preferable not to rename the existing types, it makes it very difficult to tell what has actually changed. Add a deprecated comment instead. If there are new types call them "*Next" or something for now.

This is in now. The diff is much nicer.

@gak gak added this pull request to the merge queue Aug 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2024
@gak gak enabled auto-merge August 11, 2024 23:44
@gak gak added this pull request to the merge queue Aug 11, 2024
Merged via the queue into main with commit b42b52c Aug 11, 2024
17 checks passed
@gak gak deleted the gak/kms branch August 11, 2024 23:50
@gak gak mentioned this pull request Aug 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2024
@gak @github-actions @matt2e
feat(KMS): derive keys for logs and async (#2338)
2a3edbc 
Fixes #2290 
Follows #2312 
Needs work: #2346 #2348 

> [!CAUTION]
> Will nuke logs and async columns!

- Uses KMS via tink `FTL_KMS_URI`, so `fake-kms://` or `aws-kms://` will
work. Omitting will not encrypt.
- Remove old plaintext keys envs.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Toohey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas left review comments

@alecthomas alecthomas alecthomas approved these changes

@AlexSzlavik AlexSzlavik Awaiting requested review from AlexSzlavik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gak @alecthomas @stuartwdouglas