Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more reasonable defaults for retry directives #2294

Merged
merged 3 commits into from
Aug 8, 2024
Merged

fix: more reasonable defaults for retry directives #2294

merged 3 commits into from
Aug 8, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Aug 8, 2024 •
edited
Loading

closes #2292
Previous behaviour:

  • Default max backoff is 24hrs.
  • Default retry count was 100

New behaviour:

  • Default max backoff is 1hr (or min backoff if it is larger), but users can specify values up to 24hrs still.
  • Default retry count is now 10

@matt2e matt2e requested a review from alecthomas as a code owner August 8, 2024 01:19
@matt2e matt2e requested review from a team and deniseli and removed request for a team August 8, 2024 01:19
@ftl-robot ftl-robot mentioned this pull request Aug 8, 2024
Open
@matt2e matt2e merged commit 86a94b0 into main Aug 8, 2024
18 checks passed
@matt2e matt2e deleted the matt2e/reasonable-retry-count branch August 8, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@deniseli deniseli Awaiting requested review from deniseli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change retry count default to something reasonable
1 participant
@matt2e