fix: inlining can break module detection #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
deniseli
and removed request for
a team
Open
alecthomas
approved these changes
Aug 1, 2024
stuartwdouglas
force-pushed
the
stuartwdouglas/caller-reflection
branch
2 times, most recently
from
c17a60c to
8037efc
Compare
It seems that in some curcumstances inlining can break module detection, resulting in incorrect 'must be called from an FTL module' errors.
stuartwdouglas
force-pushed
the
stuartwdouglas/caller-reflection
branch
from
8037efc to
13748d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in some curcumstances inlining can break module detection, resulting in incorrect 'must be called from an FTL module' errors.