Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove all the crazy bundled files #2183

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: remove all the crazy bundled files #2183

merged 1 commit into from
Jul 29, 2024

Conversation

wesbillman
Copy link
Collaborator

Downgrade codemirror-json-schema to fix the massive bundle size based on the comments here. After downgrading this is the new bundled output:

> tsc && vite build

vite v4.5.3 building for production...
✓ 1481 modules transformed.
dist/index.html                       0.65 kB │ gzip:   0.41 kB
dist/assets/favicon-2732bf7e.ico     15.41 kB
dist/assets/index-1905dbdc.css       52.20 kB │ gzip:   9.56 kB
dist/assets/index-5b44d2c3.js     1,662.44 kB │ gzip: 526.12 kB

Thanks @mistermoe for searching github issues with me! :)

@wesbillman wesbillman requested a review from alecthomas as a code owner July 26, 2024 18:51
@wesbillman wesbillman requested review from a team and deniseli and removed request for a team July 26, 2024 18:51
@ftl-robot ftl-robot mentioned this pull request Jul 26, 2024
Open
@wesbillman wesbillman requested a review from gak July 26, 2024 19:06
@mistermoe
Copy link
Collaborator

naisuu!

@alecthomas
Copy link
Collaborator

OMG

gak
gak approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@gak gak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100x better then what I was going to do. Nice!

@wesbillman wesbillman merged commit d0f1370 into main Jul 29, 2024
61 checks passed
@wesbillman wesbillman deleted the downgrade-codemirror-json-schema branch July 29, 2024 16:38
@wesbillman wesbillman mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistermoe mistermoe mistermoe approved these changes

@gak gak gak approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas

@deniseli deniseli Awaiting requested review from deniseli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wesbillman @mistermoe @alecthomas @gak