Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete observability package from Go SDK #2182

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

deniseli
Copy link
Contributor

@deniseli deniseli commented Jul 26, 2024

Part 1 of #2026

This deletes the whole observability package from the Go SDK, since no one is using it yet. We'll replace it with an interface that better aligns with our internal otel usage patterns once that's more mature.

@ftl-robot ftl-robot mentioned this pull request Jul 26, 2024
@deniseli deniseli marked this pull request as ready for review July 26, 2024 17:27
@deniseli deniseli requested a review from alecthomas as a code owner July 26, 2024 17:27
@deniseli deniseli requested review from a team and worstell and removed request for a team July 26, 2024 17:27
Copy link
Collaborator

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! We can add this stuff back in once we have a better idea of what (if anything) might be useful. In the meantime, customers can use otels normal API to track all the metrics they want

@deniseli deniseli merged commit b9908a6 into main Jul 26, 2024
60 checks passed
@deniseli deniseli deleted the dli/del-obs-sdk branch July 26, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants