feat: finish migrating schema extraction!!!! #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
a team,
deniseli and
wesbillman
and removed request for
a team
worstell
force-pushed
the
worstell/20240725-migrate-fsm
branch
from
6449427 to
fa94aeb
Compare
|
Yayyyy! Epic job Lizzy, nice one 😀 |
worstell
force-pushed
the
worstell/20240725-migrate-fsm
branch
from
fa94aeb to
9b3e5f6
Compare
wesbillman
approved these changes
Jul 25, 2024
ftl-project.toml
Outdated
Comment on lines
4
to
5
| hermit = false | ||
| no-git = false |
There was a problem hiding this comment.
are these required for the schema extraction changes? Similar to the modules.test below.
There was a problem hiding this comment.
ah not sure where these got picked up, thanks for flagging. let me check them out
Comment on lines
+74
to
+77
| func NewCallDeclExtractor[T schema.Decl](name string, extractFunc ExtractCallDeclFunc[T], callPaths ...string) *analysis.Analyzer { | ||
| type Tag struct{} // Tag uniquely identifies the fact type for this extractor. | ||
| return NewExtractor(name, (*DefaultFact[Tag])(nil), runExtractCallDeclsFunc[T](extractFunc, callPaths...)) | ||
| } |
- migrates FSMs to new extractor - deletes legacy code fixes #1518
worstell
force-pushed
the
worstell/20240725-migrate-fsm
branch
from
9b3e5f6 to
6f44efb
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1518