Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(log): add test for logger #2169

Merged
merged 1 commit into from
Jul 25, 2024
Merged

chore(log): add test for logger #2169

merged 1 commit into from
Jul 25, 2024

Conversation

alecthomas
Copy link
Collaborator

@alecthomas alecthomas commented Jul 25, 2024 •
edited
Loading

No description provided.

@alecthomas alecthomas requested review from a team and deniseli and removed request for a team July 25, 2024 16:46
@ftl-robot ftl-robot mentioned this pull request Jul 25, 2024
Open
wesbillman
wesbillman approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thanks dude!

@alecthomas alecthomas force-pushed the aat/fix-test-attr-propagation branch 2 times, most recently from c9639e6 to ecad5a7 Compare July 25, 2024 18:23
@alecthomas alecthomas changed the title fix(log): propagate log attributes from infof, etc. helpers chore(log): add test for logger Jul 25, 2024
@alecthomas alecthomas force-pushed the aat/fix-test-attr-propagation branch 2 times, most recently from 988d451 to a68383b Compare July 25, 2024 18:31
@alecthomas alecthomas force-pushed the aat/fix-test-attr-propagation branch from a68383b to c321e8e Compare July 25, 2024 18:40
@alecthomas alecthomas merged commit b6a741e into main Jul 25, 2024
59 checks passed
@alecthomas alecthomas deleted the aat/fix-test-attr-propagation branch July 25, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesbillman wesbillman wesbillman approved these changes

@deniseli deniseli Awaiting requested review from deniseli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecthomas @wesbillman