Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily remove heavy dependency in verb request code editor #2153

Closed
wants to merge 2 commits into from

Conversation

gak
Copy link
Contributor

@gak gak commented Jul 24, 2024

Related to #2147

It was taking some time go patch the dependency, so I put this out in the mean time to reduce build times.

@ftl-robot ftl-robot mentioned this pull request Jul 24, 2024
@gak gak force-pushed the gak/code-editor-temp-rm-dep branch from 27992d1 to 18c36e6 Compare July 24, 2024 20:48
@gak gak marked this pull request as ready for review July 24, 2024 20:53
@gak gak requested a review from alecthomas as a code owner July 24, 2024 20:53
@gak gak requested review from a team and wesbillman and removed request for a team July 24, 2024 20:53
@wesbillman
Copy link
Collaborator

Oh shoot! I responded on the issue instead of here 🤦 #2147

@gak
Copy link
Contributor Author

gak commented Jul 25, 2024

Going to pause this change for now since it doesn't seem to affect CI that much and we have other plans like tree shaking. Plus it's a very useful feature to just take away!

@gak gak closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants