fix: add ability to delay runner registration #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
matt2e
and removed request for
a team
Open
wesbillman
approved these changes
Jul 23, 2024
We think there may be some issues with runners registering themselves before istio is fully ready, resulting in RBAC errors. This workaround should allow for a delay that will prevent this. Possible fix for #2059
stuartwdouglas
force-pushed
the
stuartwdouglas/runner-start-delay
branch
from
16c3b0b to
c046f03
Compare
matt2e
approved these changes
Jul 23, 2024
alecthomas
reviewed
Jul 24, 2024
| go func() { | ||
| // In some environments we may want a delay before registering the runner | ||
| // We have seen istio race conditions that we think this will help | ||
| startDelay := os.Getenv("FTL_RUNNER_START_DELAY") |
There was a problem hiding this comment.
This should be a Kong flag on the Config struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We think there may be some issues with runners registering themselves before istio is fully ready, resulting in RBAC errors.
This workaround should allow for a delay that will prevent this.
Possible fix for #2059