fix: wrap errors in ReplaceDeployment, don’t hide errconflicts #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
commented
Jul 18, 2024
| @@ -724,24 +724,28 @@ func (d *DAL) SetDeploymentReplicas(ctx context.Context, key model.DeploymentKey | |||
| return nil | |||
| } | |||
|
|
|||
| var ErrReplaceDeploymentAlreadyActive = errors.New("deployment already active") | |||
There was a problem hiding this comment.
I don't know if this is how we do it anywhere else, defining an error for a specific func. Is this kosher?
Open
wesbillman
approved these changes
Jul 18, 2024
matt2e
force-pushed
the
matt2e/wrap-replace-deploy-errs
branch
from
e74c23b to
9cabe4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also logs now include old and new deployment keys