fix: setting secrets and configs error with aliased field names #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
a team and
deniseli
and removed request for
a team
Open
wesbillman
force-pushed
the
use-transformed-alias-fields-in-secret-and-config-set
branch
from
77197d8 to
4514a96
Compare
wesbillman
commented
Jul 17, 2024
Comment on lines
+404
to
+406
| `failed to transform aliased fields: 0:0: expected 'name' field to be a string, got int`}, | ||
| {&schema.Ref{Name: "TypeEnumRequest", Module: "test"}, obj{"message": "Hello"}, | ||
| `malformed enum type test.TypeEnumRequest.message: expected structure is {"name": "<variant name>", "value": <variant value>}`}, | ||
| `failed to transform aliased fields: 0:0: expected map, got string`}, |
There was a problem hiding this comment.
@safeer we might want to come back and fix up these error messages if possible to make them more readable
mistermoe
approved these changes
Jul 17, 2024
wesbillman
deleted the
use-transformed-alias-fields-in-secret-and-config-set
branch
deniseli
reviewed
Jul 17, 2024
| @@ -211,6 +216,7 @@ func ValidateJSONValue(fieldType Type, path path, value any, sch *Schema) error | |||
| return nil | |||
| } | |||
|
|
|||
| // ValidateRequestMap validates a given JSON map against the provided schema. | |||
| func ValidateRequestMap(ref *Ref, path path, request map[string]any, sch *Schema) error { | |||
There was a problem hiding this comment.
Note for future reference:
Since this function is only called by ingress.BuildRequestBody and ValidateJSONValue above, we could have this function call TransformFromAliasedFields directly. Then, the caller doesn't need to know to do it, so we can prevent issues like this in the future.
Discussed on Slack - we'll leave this as is for now to keep everything as stable as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error where
when set with
secret set{"first-name": "whatever"}