fix: remove pg_notify usage in favor of polling #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
a team and
matt2e
and removed request for
a team
Open
wesbillman
commented
Jul 17, 2024
| previousDeployments := make(map[string]deploymentState) | ||
|
|
||
| for { | ||
| delay := time.Millisecond * 500 |
There was a problem hiding this comment.
Do we want this to be configurable maybe?
There was a problem hiding this comment.
I vote for getting it in as is and adding an option if there's a need
wesbillman
commented
Jul 17, 2024
Comment on lines
+63
to
+67
| hasher := sha256.New() | ||
| data := []byte(deployment.Schema.String()) | ||
| if _, err := hasher.Write(data); err != nil { | ||
| return deploymentState{}, fmt.Errorf("failed to hash schema: %w", err) | ||
| } |
There was a problem hiding this comment.
This is the hashing I had to change to. It seemed like sha256.fromBytes just didn't compute a different has at all, but maybe I was using it wrong.
wesbillman
commented
Jul 17, 2024
| newState := moduleStateEntry{ | ||
| hash: sha256.FromBytes(moduleSchemaBytes), |
There was a problem hiding this comment.
This seemed to compute the same hash every time even if the schema changed.
gak
approved these changes
Jul 17, 2024
wesbillman
force-pushed
the
remove-pg-notify-usage
branch
from
e528974 to
30add04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2087