Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only check for op if 1Password holds secrets #2093

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix: only check for op if 1Password holds secrets #2093

merged 1 commit into from
Jul 17, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jul 17, 2024 •
edited
Loading

fixes #2090

@matt2e matt2e requested a review from alecthomas as a code owner July 17, 2024 03:31
@matt2e matt2e requested review from a team and worstell and removed request for a team July 17, 2024 03:31
@ftl-robot ftl-robot mentioned this pull request Jul 17, 2024
Open
@matt2e matt2e merged commit 894b473 into main Jul 17, 2024
60 checks passed
@matt2e matt2e deleted the matt2e/avoid-checking-op branch July 17, 2024 03:52
@worstell worstell added the approved Marks an already closed PR as approved label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@worstell worstell Awaiting requested review from worstell

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

op (1password) tries to be executed when calling unrelated commands
2 participants
@matt2e @worstell