Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only deregister runner if runner was ever inserted #2082

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jul 16, 2024

fixes #2068

Errors can occur after we were adding the defer and when we would try upserting the runner.
This PR makes it so we only add the defer once we have upserted the runner

@matt2e matt2e requested a review from alecthomas as a code owner July 16, 2024 04:14
@matt2e matt2e requested review from a team and wesbillman and removed request for a team July 16, 2024 04:14
@ftl-robot ftl-robot mentioned this pull request Jul 16, 2024
@gak gak self-requested a review July 16, 2024 04:20
Copy link
Contributor

@gak gak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice fix. This one is probably a bit tricky to repro in an integration test!

@matt2e matt2e merged commit 3bc38d6 into main Jul 16, 2024
56 checks passed
@matt2e matt2e deleted the matt2e/fix-deregister-runner branch July 16, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not deregister runner on new deployment
2 participants