Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inject newlines to improve readability of just otel-stream output #2078

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

deniseli
Copy link
Contributor

Part 3 of #2020

This PR injects newlines between blocks in just otel-stream's docker container output. We should ideally add color + bolding to this as well, which can be done by piping to a very similar sed command, but moving forward without that for now to save time.

Example snippet of the output:

Metric #2
Descriptor:
     -> Name: rpc.server.response.size
     -> Description: Measures size of RPC response messages (uncompressed).
     -> Unit: By
     -> DataType: Histogram
     -> AggregationTemporality: Cumulative

HistogramDataPoints #0
Data point attributes:
     -> rpc.grpc.status_code: Int(0)
     -> rpc.method: Str(Ping)
     -> rpc.service: Str(xyz.block.ftl.v1.VerbService)
     -> rpc.system: Str(grpc)
StartTimestamp: 2024-07-16 00:02:17.426033 +0000 UTC
Timestamp: 2024-07-16 00:02:37.427409 +0000 UTC
Count: 1
Sum: 0.000000
Min: 0.000000
Max: 0.000000

ExplicitBounds #0: 0.000000

ExplicitBounds #1: 5.000000

ExplicitBounds #2: 10.000000

@ftl-robot ftl-robot mentioned this pull request Jul 16, 2024
@deniseli deniseli marked this pull request as ready for review July 16, 2024 00:13
@deniseli deniseli requested a review from alecthomas as a code owner July 16, 2024 00:13
@deniseli deniseli requested review from a team and wesbillman and removed request for a team July 16, 2024 00:13
@deniseli deniseli merged commit 2938311 into main Jul 16, 2024
56 checks passed
@deniseli deniseli deleted the dli/pretty-tui branch July 16, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants