Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test #2067

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: flaky test #2067

merged 1 commit into from
Jul 12, 2024

Conversation

worstell
Copy link
Contributor

duplicates need to be declared in separate files (parent and child) for error report test. otherwise the ordering of which is discovered first may change and the test is flaky

@worstell worstell requested a review from alecthomas as a code owner July 12, 2024 21:12
@worstell worstell requested review from a team and deniseli and removed request for a team July 12, 2024 21:12
@ftl-robot ftl-robot mentioned this pull request Jul 12, 2024
duplicates need to be declared in separate files (parent and child) for error report test. otherwise the ordering of which is discovered first may change and the test is flaky
@worstell worstell force-pushed the worstell/20240712-fix-flaky-test branch from 70d6bdb to 8f43458 Compare July 12, 2024 21:19
@worstell worstell merged commit 58b22ff into main Jul 12, 2024
54 checks passed
@worstell worstell deleted the worstell/20240712-fix-flaky-test branch July 12, 2024 21:25
@deniseli deniseli added the approved Marks an already closed PR as approved label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants