fix: some fixes! #2066
Merged
fix: some fixes! #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
worstell
commented
Jul 12, 2024
•
worstell
commented
- fixes a code gen issue for types.ftl.go
- validate global uniquness on Decl names (required because ref->Decl resolution breaks if two Decls have the same name, even of different types)
- fixes logic that determines if path is local because pass.Pkg may not be root module package
Open
worstell
force-pushed
the
worstell/20240712-remove-verb-name-error
branch
2 times, most recently
from
05f6d3b to
87fcec9
Compare
worstell
force-pushed
the
worstell/20240712-remove-verb-name-error
branch
5 times, most recently
from
d4d6a89 to
7fc4ea9
Compare
- fixes a code gen issue for types.ftl.go - validate global uniquness on Decl names (required because ref->Decl resolution breaks if two Decls have the same name, even of different types) - fixes logic that determines if path is local because pass.Pkg may not be root module package
worstell
force-pushed
the
worstell/20240712-remove-verb-name-error
branch
from
7fc4ea9 to
043fcdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.