feat: asynchronous providers #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
requested review from
a team and
wesbillman
and removed request for
a team
Open
gak
reviewed
Jul 12, 2024
| c.lastSyncAttempt = optional.Some(clock.Now()) | ||
| err := c.provider.Sync(ctx, c.values) | ||
| if err != nil { | ||
| logger.Errorf(err, "Error syncing %s", c.provider.Key()) |
There was a problem hiding this comment.
This happens when a provider fails? eg asm timeout? Does the backoff time out?
There was a problem hiding this comment.
This happens when a provider fails to sync (such as ASM timing out, or 1Password not getting authorized).
The backoff schedules the sync to try again in a future round of async provider syncs, starting at 1s later, exponentially growing and then maxing out at a 2 min maximum (syncMaxBackoff).
Does that answer your question @gak?
gak
approved these changes
Jul 12, 2024
matt2e
force-pushed
the
matt2e/cache-secrets
branch
from
e82705f to
40cc1df
Compare
matt2e
force-pushed
the
matt2e/cache-secrets
branch
from
0975745 to
32a0eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1949
Changes:
Providerinterface into:SynchronousProvider: same as old interface, can load values from the data source on-demandAsynchronousProvider: used by providers that prefer to sync with their data sourceManagerowns acachewhich syncs asynchronous providersManageris getting values from an asynchronous provider, it now accesses it viacacheManageris setting values for an asynchronous provider, it directly sets it with the provider and then notifies the cacheOnePasswordProvideris now anAsynchronousProviderso that we don't cause multiple annoying authorization promptsASMis now anAsynchronousProviderwith it's previoussecretsCachenow being repurposed to work more generally.