Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not panic if an error occurs making a call #2047

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: do not panic if an error occurs making a call #2047

merged 1 commit into from
Jul 11, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jul 11, 2024 •
edited
Loading

fixes #2045
Do not access response.Msg if response may be nil because we have an error

@matt2e matt2e requested a review from alecthomas as a code owner July 11, 2024 04:57
@matt2e matt2e requested review from a team, deniseli and gak and removed request for a team July 11, 2024 04:57
@ftl-robot ftl-robot mentioned this pull request Jul 11, 2024
Open
@matt2e matt2e merged commit d41616f into main Jul 11, 2024
51 checks passed
@matt2e matt2e deleted the matt2e/call-failure-causes-panic branch July 11, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistermoe mistermoe mistermoe approved these changes

@alec-brooks alec-brooks alec-brooks approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@deniseli deniseli Awaiting requested review from deniseli

@gak gak Awaiting requested review from gak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in production when ingress call comes in
3 participants
@matt2e @alec-brooks @mistermoe