fix: sync stub references for each build group #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
a team and
deniseli
and removed request for
a team
Open
wesbillman
force-pushed
the
sync-stub-references
branch
from
df8c08e to
fb8b9c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the build engine to generate stubs for all known schemas at build time. After a build group is built, we then sync the stub references to help users get auto completions and imports in their IDEs or text editors.
It essentially changes the way we gather schemas for the module(s) we're building.
In
gosyncing the stub references means that we update thego.workfile for each built module to include ALL shared module stubs. This helps when a module is adding a shared module as a dependency.