Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transitive type loop #2037

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: transitive type loop #2037

merged 1 commit into from
Jul 10, 2024

Conversation

worstell
Copy link
Contributor

No description provided.

@worstell worstell requested a review from alecthomas as a code owner July 10, 2024 20:14
@worstell worstell requested review from a team and matt2e and removed request for a team July 10, 2024 20:14
@ftl-robot ftl-robot mentioned this pull request Jul 10, 2024
Open
@worstell worstell merged commit a4e4b96 into main Jul 10, 2024
51 checks passed
@worstell worstell deleted the worstell/20240710-fix-transitive branch July 10, 2024 20:34
@matt2e
Copy link
Collaborator

matt2e commented Jul 10, 2024

LGTM 👍 the new code looks good, but I can't tell what was wrong with the previous code 🤷‍♂️

@matt2e matt2e added the approved Marks an already closed PR as approved label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas

@matt2e matt2e Awaiting requested review from matt2e

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worstell @matt2e