Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ftltest context option order insensivity #2018

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

jonathanj-square
Copy link
Contributor

fixes #1866

introduces a rudimentary partial ordering scheme for context options - this is used to sort them before they get executed to build the context

@jonathanj-square jonathanj-square requested review from a team and matt2e and removed request for a team July 9, 2024 18:04
@ftl-robot ftl-robot mentioned this pull request Jul 9, 2024
Copy link
Collaborator

@matt2e matt2e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonathanj-square jonathanj-square merged commit 7354e2d into main Jul 10, 2024
48 checks passed
@jonathanj-square jonathanj-square deleted the jonathanj/issue_1866 branch July 10, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider not being so strict about ftltest context option ordering
2 participants