Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panic in build engine when module building fails #1985

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: panic in build engine when module building fails #1985

merged 1 commit into from
Jul 5, 2024

Conversation

wesbillman
Copy link
Collaborator

@wesbillman wesbillman commented Jul 5, 2024 •
edited
Loading

Fixes #1984

@wesbillman wesbillman requested a review from alecthomas as a code owner July 5, 2024 17:21
@wesbillman wesbillman requested review from a team and deniseli and removed request for a team July 5, 2024 17:21
@ftl-robot ftl-robot mentioned this pull request Jul 5, 2024
Open
@wesbillman wesbillman merged commit a183b6f into main Jul 5, 2024
45 checks passed
@wesbillman wesbillman deleted the fix-panic-in-buildengine branch July 5, 2024 17:49
@deniseli deniseli added the approved Marks an already closed PR as approved label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@deniseli deniseli Awaiting requested review from deniseli

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic in buildengine if time fails to build
2 participants
@wesbillman @deniseli