ci: ensure frozen migrations #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
approved these changes
Jul 4, 2024
scripts/ensure-frozen-migrations
Outdated
| local changed_files | ||
|
|
||
| # Get list of changed SQL files compared to main branch | ||
| changed_files=$(git diff --name-only origin/main -- "$sql_dir"/*.sql) |
There was a problem hiding this comment.
Use merge-base here (see linting for example), origin main isn't reliable
|
Noice, thanks gak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1962
just ensure-frozen-migrations.