fix: validate project config #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
requested review from
a team and
wesbillman
and removed request for
a team
Open
matt2e
force-pushed
the
matt2e/validate-project-config
branch
2 times, most recently
from
213a13d to
fbe94b9
Compare
wesbillman
approved these changes
Jul 3, 2024
| @@ -61,7 +61,7 @@ func tempConfigPath(t *testing.T, existingPath string, prefix string) string { | |||
| var existing []byte | |||
| var err error | |||
| if existingPath == "" { | |||
| existing = []byte{} | |||
| existing = []byte("name = \"generated\"") | |||
There was a problem hiding this comment.
nit: You might be able to use backticks here:
`name = "generated"`| @@ -47,6 +47,26 @@ func (c Config) Root() string { | |||
| return filepath.Dir(c.Path) | |||
| } | |||
|
|
|||
| // Validate checks that the configuration is valid. | |||
| func (c Config) Validate() error { | |||
There was a problem hiding this comment.
Do we need a test for this one, or is it covered by other tests that use Create?
This was done in a previous PR: #1952 👍 |
matt2e
force-pushed
the
matt2e/validate-project-config
branch
from
b5db7a2 to
0b15159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates project config files.
This breaks previous cases where
ftl config setand similar would be able to create the project toml if it wasn't already created. Now that a project's name is required, an invalid project config would have been created.It is now a requirement to go through
ftl init <name> <dir>