feat!: store all 1password secrets in a single entry #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
I don't plan on merging this in yet until I have more PRs ready that will help transition existing projects |
matt2e
force-pushed
the
matt2e/1p-single-entry
branch
9 times, most recently
from
17a2306 to
acc10b5
Compare
deniseli
approved these changes
Jul 9, 2024
| @@ -28,21 +29,25 @@ func (o OnePasswordProvider) Delete(ctx context.Context, ref Ref) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (o OnePasswordProvider) itemName() string { | |||
| return o.ProjectName + ".secrets" | |||
There was a problem hiding this comment.
Does this need the "ftl." + prefix, or does that get added somewhere else?
There was a problem hiding this comment.
I moved away from the ftl. prefix, but i hadn't updated the documentation. good catch!
| assert.Error(t, err) | ||
|
|
||
| var pw1 = []byte("hunter1") | ||
| var pw2 = []byte(`{ | ||
| "user": "root", | ||
| "password": "hunter🪤" | ||
| "password": "hun\\ter🪤" |
matt2e
force-pushed
the
matt2e/1p-single-entry
branch
from
acc10b5 to
a2ce3e0
Compare
matt2e
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1947
closes #1772
Creates an entry in 1Password called
<projectname>.secretswith each secret stored in a password field called<modulename>.<secretname>Username is set to a warning string as that is presented at the top of the 1Password UI.
This will break existing secrets stored in 1Password. Migration can be done using commands made available in: #1982