Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce ASM batch size to stay within filter limit of 10 #1940

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jul 2, 2024

fixes #1937
Not able to reproduce the issue in local stack. A tag filter + 20 secret names worked fine there.

@matt2e matt2e requested a review from alecthomas as a code owner July 2, 2024 22:53
@matt2e matt2e requested review from a team and worstell and removed request for a team July 2, 2024 22:53
@ftl-robot ftl-robot mentioned this pull request Jul 2, 2024
@alecthomas
Copy link
Collaborator

Frustrating. It's probably a soft limit in AWS that you can request an upgrade for, but this seems like a good idea.

@matt2e matt2e merged commit 116e8ac into main Jul 2, 2024
46 checks passed
@matt2e matt2e deleted the matt2e/asm-batch-fix branch July 2, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTL failing when using ASM
2 participants