New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vscode): handle lsp crashes #1934

Merged

gak merged 1 commit into main from gak/vscode-startup-error-handling

Jul 2, 2024

Contributor

gak commented Jul 2, 2024

Fixes #1890

Detect when FTL stops via crash and shows an error on the status bar.
When restarting, start spinning again.
Tested manually with both examples in If FTL can't start for some reason, attempting to start it again results in failure to start + icon spinning #1890 and also killing the process directly.


          fix(vscode): handle lsp crashes

de4076f

gak requested a review from alecthomas as a code owner

July 2, 2024 21:13

gak requested review from a team and matt2e and removed request for a team

July 2, 2024 21:13

ftl-robot mentioned this pull request

Open

alecthomas approved these changes

View reviewed changes

gak merged commit 2fd15ac into main

46 checks passed

gak deleted the gak/vscode-startup-error-handling branch

July 2, 2024 21:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet