Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode/intellij debugger configs #1918

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

worstell
Copy link
Contributor

@worstell worstell commented Jul 1, 2024

No description provided.

@worstell worstell requested a review from alecthomas as a code owner July 1, 2024 22:17
@worstell worstell requested review from a team and matt2e and removed request for a team July 1, 2024 22:17
@ftl-robot ftl-robot mentioned this pull request Jul 1, 2024
Justfile Outdated
@@ -50,7 +50,12 @@ build-generate:
build +tools: build-protos build-zips build-frontend
#!/bin/bash
shopt -s extglob
for tool in $@; do mk "{{RELEASE}}/$tool" : !(build|integration) -- go build -o "{{RELEASE}}/$tool" -tags release -ldflags "-X github.com/TBD54566975/ftl.Version={{VERSION}} -X github.com/TBD54566975/ftl.Timestamp={{TIMESTAMP}}" "./cmd/$tool"; done

if [ "${DEBUG:-}" = "true" ]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEBUG=true just build ftl will build with debug info. it's needed for the debugger but apparently creates suboptimal performance for the binary, so gating it to insulate the actual release binary

@worstell worstell force-pushed the worstell/20240701-add-ftl-debug branch 3 times, most recently from 3446616 to fabe2eb Compare July 2, 2024 00:15
@alecthomas
Copy link
Collaborator

Maybe add a section to the CONTRIBUTING.md? We haven't been great with that, but maybe this would be a good time to start, I dunno.

@worstell worstell force-pushed the worstell/20240701-add-ftl-debug branch 3 times, most recently from b269df3 to 926b565 Compare July 2, 2024 20:01
@worstell worstell force-pushed the worstell/20240701-add-ftl-debug branch from 926b565 to 2e25ec9 Compare July 2, 2024 22:32
@worstell worstell enabled auto-merge (squash) July 2, 2024 22:33
@worstell worstell disabled auto-merge July 2, 2024 22:37
@worstell worstell merged commit 4cf3adf into main Jul 2, 2024
45 checks passed
@worstell worstell deleted the worstell/20240701-add-ftl-debug branch July 2, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants