feat: verb request and response types can be any FTL type #1912
Conversation
|
I realised afterwards that the issue refers to only making the response type more lenient, not the request type. Lmk if I should keep the request type strict |
| if err != nil { | ||
| return fmt.Errorf("HTTP request body is not valid JSON: %w", err) |
There was a problem hiding this comment.
It's odd to me that these checks are in the ingress package even though they check the validity of request data for all requests.
I've removed "HTTP" from the error message because this is being used outside of HTTP use cases
There was a problem hiding this comment.
It doesn't make much sense for this function to be in this package anymore really.
matt2e
force-pushed
the
matt2e/non-struct-req-resp
branch
from
dff622c to
6da5eea
Compare
| if err != nil { | ||
| return fmt.Errorf("HTTP request body is not valid JSON: %w", err) |
There was a problem hiding this comment.
It doesn't make much sense for this function to be in this package anymore really.
|
Request or response type is fine, let's merge. |
matt2e
force-pushed
the
matt2e/non-struct-req-resp
branch
from
6da5eea to
c71696d
Compare
|
Should we merge this one @matt2e or are we holding off for stability? |
# Conflicts: # backend/controller/ingress/ingress.go
matt2e
force-pushed
the
matt2e/non-struct-req-resp
branch
from
c71696d to
0e30991
Compare
matt2e
force-pushed
the
matt2e/non-struct-req-resp
branch
from
7f0c29a to
4b103b3
Compare
closes #1854