Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: database-backed secret resolver #1901

Merged
merged 8 commits into from
Jul 3, 2024
Merged

fix: database-backed secret resolver #1901

merged 8 commits into from
Jul 3, 2024

Conversation

safeer
Copy link
Contributor

@safeer safeer commented Jun 27, 2024 •
edited
Loading

Fixes #1887

@ftl-robot ftl-robot mentioned this pull request Jun 27, 2024
Open
alecthomas
alecthomas reviewed Jun 27, 2024
View reviewed changes
backend/controller/admin/admin.go Outdated Show resolved Hide resolved
backend/controller/sql/schema/001_init.sql Outdated Show resolved Hide resolved
backend/protos/xyz/block/ftl/v1/ftl.proto Outdated Show resolved Hide resolved
@safeer safeer force-pushed the saf/db-secret-provider branch 2 times, most recently from 94c4f88 to 6e03164 Compare July 1, 2024 22:31
@safeer safeer changed the title WIP: db-backed secret resolver fix: database-backed secret resolver Jul 1, 2024
@safeer safeer marked this pull request as ready for review July 1, 2024 22:43
@safeer safeer requested review from a team and deniseli and removed request for a team July 1, 2024 22:43
alecthomas
alecthomas approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for that delay!

common/configuration/dal/dal.go Outdated Show resolved Hide resolved
@safeer safeer force-pushed the saf/db-secret-provider branch from 2fd4fd6 to 96ee70e Compare July 3, 2024 21:51
@safeer safeer merged commit 574918b into main Jul 3, 2024
47 checks passed
@safeer safeer deleted the saf/db-secret-provider branch July 3, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@deniseli deniseli Awaiting requested review from deniseli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a database-backed secret resolver (basically identical to the config one, so consider refactoring that)
2 participants
@safeer @alecthomas