fix: when using module-dirs from project, make dirs absolute #1690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue where the LSP was not clearing the diagnostics correctly for modules when rebuilding.
It turned out that the
module.Dir
was only relative when loaded from the projecttoml
vs. absolute when used with"."
orftl dev example/go
. This change makes sure we set the absolute paths on theconfig.ModuleDirs
andconfig.ExternalDirs
when loading them fromftl-project.toml
files.Before this change the
lsp
would try to clear files with the following path. This would result in LSP errors never being cleared.lsp: Clearing diagnostics for file:///examples/go/echo
This update, ensures that path is absolute
lsp: Clearing diagnostics for file:///Users/wesbillman/dev/ftl/examples/go/echo