fix: add severity levels to build errors #1285 #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanj-square
requested review from
a team and
matt2e
and removed request for
a team
github-actions
bot
changed the title
Open
jonathanj-square
changed the title
alecthomas
reviewed
May 21, 2024
| @@ -132,6 +133,18 @@ func generateStruct(t reflect.Type, messages map[string]string) { | |||
| messages[t.Name()] = w.String() | |||
| } | |||
|
|
|||
| // generateWellKnownNestedEnums generates the well-known nested enums for a given reflect.Type. | |||
| // Reflection cannot discover type aliased enums, so they need to get generated manually. | |||
| func generateWellKnownNestedEnums(t reflect.Type, w *strings.Builder) { | |||
There was a problem hiding this comment.
Ah awesome, I've been meaning to do something about enums for a while now.
This, and the "chicken and egg" problem of having the proto schema rely on the Go schema compiling and existing would be nice to solve in the general case. I think the permanent solution is to switch to static analysis. But this is great for now.
alecthomas
approved these changes
May 21, 2024
backend/schema/protobuf_test.go
Outdated
| @@ -14,3 +14,7 @@ func TestProtoRoundtrip(t *testing.T) { | |||
| assert.NoError(t, err) | |||
| assert.Equal(t, Normalise(testSchema), Normalise(actual)) | |||
| } | |||
|
|
|||
| func TestErrorProtoGeneration(t *testing.T) { | |||
|
I think this needs to be plumbed through to the LSP too. |
jonathanj-square
deleted the
jonathanj/add-severity-levels-to-build-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.