fix: ftltest config: use ConfigPaths with envar fallback #1543
Conversation
safeer
force-pushed
the
ftltest-use-configpaths
branch
from
c3cb181 to
e31b468
Compare
| if ok { | ||
| paths = strings.Split(envValue, ",") | ||
| } else { | ||
| paths = pc.ConfigPaths(paths) |
There was a problem hiding this comment.
Should we confirm that paths isn't empty and return the same preprocessingErr error from before?
There was a problem hiding this comment.
My intention here is to have the same behavior as main.go, which allows LoadConfig to return an empty config after attempting to fall back on the envar, then the gitroot. I think having that parity makes sense?
There was a problem hiding this comment.
Ah, I see. I was wondering because I can't think of a reason why someone would use WithProjectFiles without any paths. From that perspective, I'd find it useful to get the error message during development so that I know the way I'm using WithProjectFiles isn't actually doing anything. main.go wouldn't want to error in that case because the project toml isn't required, whereas if someone is explicitly invoking WithProjectFiles, I'd assume they have some intent to actually use a project toml.
There was a problem hiding this comment.
I think it's clear that if you're not passing explicit config files to WithProjectFiles() that whatever its described behaviour is is in effect. The ftl-project.toml file is designed to be the "default" for a project, and having it consistent across the CLI and tests is fine.
Follow up to #1539 We use `react-codemirror2`, which requires `codemirror` major version `5.*`, even on their [master branch](https://github.com/scniro/react-codemirror2/blob/master/package.json). Since we have no reason to stop using `react-codemirror2`, we just need to stop codemirror from continuing to get updated automatically by renovate. After this PR merges (assuming reviewers think this looks right!), I'll close #1539.
Fixes #1502.
Adds tests to ensure we're correctly falling back to the config in
FTL_CONFIGand toftl-project.tomlin the gitroot.