Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip nil decls when building verb schema #1532

Merged
merged 1 commit into from
May 17, 2024
Merged

fix: skip nil decls when building verb schema #1532

merged 1 commit into from
May 17, 2024

Conversation

wesbillman
Copy link
Collaborator

No description provided.

@wesbillman wesbillman requested a review from alecthomas as a code owner May 17, 2024 19:43
@wesbillman wesbillman requested review from a team and matt2e and removed request for a team May 17, 2024 19:43
@ftl-robot ftl-robot mentioned this pull request May 17, 2024
Open
@wesbillman wesbillman merged commit e6c8660 into main May 17, 2024
25 checks passed
@wesbillman wesbillman deleted the fix-verbschema-for-nil-decls branch May 17, 2024 19:49
@worstell worstell added the approved Marks an already closed PR as approved label May 17, 2024
alecthomas
alecthomas reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't ever be nil decls...can you file a bug with a way to replicate

@alecthomas
Copy link
Collaborator

Or is this from a partial schema or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas left review comments

@matt2e matt2e Awaiting requested review from matt2e

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wesbillman @alecthomas @worstell