fix: explicitly need to pull docker images, fixes #1525 #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gak
requested review from
a team,
deniseli and
matt2e
and removed request for
a team
Open
alecthomas
approved these changes
May 17, 2024
internal/container/container.go
Outdated
| } | ||
| defer reader.Close() | ||
|
|
||
| _, err = io.Copy(os.Stderr, reader) |
There was a problem hiding this comment.
Grab a logger from the context with logger := log.FromContext(ctx) and use logger.WriterAt(log.Info) to get a writer that will go through the logger.
There was a problem hiding this comment.
From memory the output is designed for a terminal though, but I think there's an option to modify it...maybe? Should be fine for now.
There was a problem hiding this comment.
Works great, still messy but at least it's going through the logger.
matt2e
reviewed
May 17, 2024
| @@ -151,6 +151,11 @@ func (s *schemaImportCmd) setup(ctx context.Context) error { | |||
| } | |||
| _ = l.Close() | |||
|
|
|||
| err = container.Pull(ctx, "ollama/ollama") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output is a bit messy but it at least will show progress, rather than hiding the output.