Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase parser lookahead #1510

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: increase parser lookahead #1510

merged 1 commit into from
May 16, 2024

Conversation

alecthomas
Copy link
Collaborator

Fixes #1507. I'm really surprised we haven't hit this previously.

Fixes #1507. I'm really surprised we haven't hit this previously.
@alecthomas alecthomas requested review from a team, deniseli and gak and removed request for a team May 16, 2024 05:42
@ftl-robot ftl-robot mentioned this pull request May 16, 2024
@alecthomas alecthomas enabled auto-merge (squash) May 16, 2024 05:43
@alecthomas alecthomas merged commit 57b5402 into main May 16, 2024
24 checks passed
@alecthomas alecthomas deleted the aat/parser-lookahead branch May 16, 2024 05:45
@alecthomas alecthomas removed request for deniseli and gak May 16, 2024 11:09
Copy link
Collaborator Author

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moo

@@ -47,7 +47,8 @@ var (
participle.Lexer(Lexer),
participle.Elide("Whitespace"),
participle.Unquote(),
participle.UseLookahead(2),
// Increase lookahead to allow comments to be attached to the next token.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@deniseli deniseli added the approved Marks an already closed PR as approved label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse a module that has more than 2 lines of comments for a Secret causes a parse error
2 participants