feat: support omitempty in custom json de/encoder #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor cleanup post merge cleanup
deniseli
requested review from
a team and
wesbillman
and removed request for
a team
Open
wesbillman
reviewed
May 8, 2024
Comment on lines
+66
to
+67
| {name: "OmitEmptyNotNull", input: validateOmitempty{"foo", "bar", "baz"}, expected: `{"shouldOmit":"foo","shouldntOmit":"bar","notTagged":"baz"}`}, | ||
| {name: "OmitEmptyNull", input: validateOmitempty{}, expected: `{"shouldntOmit":"","notTagged":""}`}, |
There was a problem hiding this comment.
Nice! I wonder if we should add some omitempty to test data .go files in a test as well to make sure it's working end-to-end?
There was a problem hiding this comment.
Great idea! I'll do that now
deniseli
added a commit
that referenced
this pull request
May 9, 2024
Addresses #1441 (comment) Tested with `go test --tags=integration ./integration/... -run TestHTTPEncodeOmitempty`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1262