Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore non-exported decls in codegen #1378

Merged
merged 1 commit into from
May 2, 2024

Conversation

wesbillman
Copy link
Collaborator

Fixes #1376

@wesbillman wesbillman requested a review from a team as a code owner May 2, 2024 00:17
@wesbillman wesbillman requested review from worstell and removed request for a team May 2, 2024 00:17
@alecthomas alecthomas mentioned this pull request May 2, 2024
@@ -82,6 +82,32 @@ func exec(cmd string, args ...string) action {
}
}

// execWithOutput runs a command from the test working directory
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should mention that the output is returned as part of the error

@alecthomas
Copy link
Collaborator

This is awesome

@wesbillman wesbillman force-pushed the respect-export-in-code-gen branch from a23d4de to ec09a41 Compare May 2, 2024 00:46
@wesbillman wesbillman merged commit 14e04e4 into main May 2, 2024
10 checks passed
@wesbillman wesbillman deleted the respect-export-in-code-gen branch May 2, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update external module code generator to not generate decls based on visibility
3 participants