Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify config/secret duplication validation logic #1337

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: simplify config/secret duplication validation logic #1337

merged 1 commit into from
Apr 26, 2024

Conversation

deniseli
Copy link
Contributor

Fixes #1121

@deniseli deniseli requested a review from a team as a code owner April 26, 2024 02:08
@deniseli deniseli requested review from matt2e and removed request for a team April 26, 2024 02:08
@alecthomas alecthomas mentioned this pull request Apr 26, 2024
Open
@deniseli deniseli mentioned this pull request Apr 26, 2024
Merged
matt2e
matt2e approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@matt2e matt2e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deniseli deniseli merged commit 7d39eb7 into main Apr 26, 2024
12 checks passed
@deniseli deniseli deleted the dli/be-dupl-notes branch April 26, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt2e matt2e matt2e approved these changes

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple usages of config usages show up in schema
3 participants
@deniseli @alecthomas @matt2e