fix: runInBackground returns error #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
wesbillman
approved these changes
Apr 25, 2024
cmd/ftl/cmd_serve.go
Outdated
| @@ -55,7 +55,10 @@ func (s *serveCmd) Run(ctx context.Context) error { | |||
| _ = KillBackgroundServe(logger) | |||
| } | |||
|
|
|||
| runInBackground(logger) | |||
| if err := runInBackground(logger); err != nil { | |||
| logger.Errorf(err, "runInBackground failed") | |||
There was a problem hiding this comment.
You might be able to remove the log message since the cmd will error as well. Otherwise, I think we might get duplicate error messages like this:
remove dup log
deniseli
force-pushed
the
dli/serve-bg-errs
branch
from
04eb5cb to
5bd3b48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1170
The new terminal output, when I force an error to return from
runInBackground, looks like: